voonhous commented on code in PR #19868:
URL: https://github.com/apache/hudi/pull/19868#discussion_r3961461366
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataMetrics.java:
##########
@@ -164,6 +181,48 @@ public void updateSizeMetrics(HoodieTableMetaClient
metaClient, HoodieBackedTabl
for (Map.Entry<String, String> e : stats.entrySet()) {
setMetric(e.getKey(), Long.parseLong(e.getValue()));
}
+ long totalBaseFiles = sumStat(stats, metadataPartitions,
STAT_COUNT_BASE_FILES);
Review Comment:
**minor:** Not blocking, but to make this concrete:
`hoodie.metadata.enable.detailed.metrics` defaults to false (c6d707c6a8bd,
#18803), added because `updateSizeMetrics` builds a `HoodieTableFileSystemView`
on the driver. So by default only `deltaCommitsSinceLastCompaction` exists, the
PR body's "four series per table" does not hold, and the ratio javadoc's "read
together with" the two totals points at gauges that are off. The three
aggregates are also derivable from the per-partition gauges this same call
emits. Could we name the config in this comment block and in the PR body?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
