smtwilio commented on code in PR #19811:
URL: https://github.com/apache/hudi/pull/19811#discussion_r3973519798
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java:
##########
@@ -220,6 +220,19 @@ public void shutdownGracefully() {
});
}
+ /**
+ * Interrupts an in-progress ingestion. Unlike {@link #shutdownGracefully()}
this neither closes nor waits: the sync
+ * is still running, and the thread owning it releases the resources once it
returns.
+ */
+ public void interruptIngestion() {
+ ingestionService.ifPresent(ds -> {
+ if (!ds.isShutdown()) {
+ log.info("Forcefully shutting down DeltaStreamer");
+ ds.shutdown(true);
Review Comment:
It is deliberate, yes! Documented it for now. You are right, the loop
already exits between rounds, but the graceful path is not reachable today.
HoodieAsyncService only offers interrupt or block for 24 hours. Happy to create
a follow up after this PR if you think it's worth adding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
