hudi-agent commented on code in PR #19082:
URL: https://github.com/apache/hudi/pull/19082#discussion_r3982219730
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala:
##########
@@ -42,33 +42,28 @@ import java.io.File
import scala.collection.JavaConverters._
-@SparkSQLCoreFlow
class TestSparkSqlCoreFlow extends HoodieSparkSqlTestBase {
Review Comment:
🤖 nit: this trims the matrix down to 6 of 16 combos, but the leftover set
isn't a clean cross-product of table type × metadata × keygen × index anymore
(e.g. GLOBAL_SIMPLE only appears with metadata=true, BLOOM/SIMPLE index only
with NonpartitionedKeyGenerator). Might be worth spelling out the selection
rule so a future contributor adding a combo keeps the balance intentional.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala:
##########
@@ -42,33 +42,28 @@ import java.io.File
import scala.collection.JavaConverters._
-@SparkSQLCoreFlow
class TestSparkSqlCoreFlow extends HoodieSparkSqlTestBase {
val colsToCompare = "timestamp, _row_key, partition_path, rider, driver,
begin_lat, begin_lon, end_lat, end_lon, fare.amount, fare.currency,
_hoodie_is_deleted"
- //params for core flow tests
+ // Params for core flow tests. This suite is the cross-Spark-version "core
flow" anchor
+ // (runs on every Spark version via the core-tests profile), so the matrix
is trimmed to a
+ // representative spread of table type, metadata on/off, key generator, and
index type.
+ // The dropped keygen/index permutations are Spark-version-independent and
remain covered
Review Comment:
🤖 Is "remain covered by the full suite" accurate here? Every block in this
suite is tagged `SparkCoreFlow`, which the full-suite runs exclude via the
default `hoodie.scalatest.tagsToExclude`, so the dropped permutations (e.g.
`COPY_ON_WRITE|true|SimpleKeyGenerator|GLOBAL_BLOOM`) don't run anywhere now.
Not a regression since the suite was dead before, but it might be worth
rewording so nobody later trims further assuming the full suite has them.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
