NickYoungPeng commented on a change in pull request #2744:
URL: https://github.com/apache/hudi/pull/2744#discussion_r606935558



##########
File path: 
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieMultiTableDeltaStreamer.java
##########
@@ -117,7 +117,9 @@ private void 
populateTableExecutionContextList(TypedProperties properties, Strin
       checkIfTableConfigFileExists(configFolder, fs, configFilePath);
       TypedProperties tableProperties = UtilHelpers.readConfig(fs, new 
Path(configFilePath), new ArrayList<>()).getConfig();
       properties.forEach((k, v) -> {
-        tableProperties.setProperty(k.toString(), v.toString());
+        if (tableProperties.get(k) == null) {

Review comment:
       I think we don't need to check for empty,because some properties allow 
to empty such as `hoodie.datasource.write.partitionpath.field`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to