hudi-agent commented on code in PR #19868:
URL: https://github.com/apache/hudi/pull/19868#discussion_r3996475487
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1570,16 +1570,55 @@ public void performTableServices(Option<String>
inFlightInstantTimestamp, boolea
String executionStatusMetricName = tableNameExists
? String.format("%s.%s", metadataTableName,
HoodieMetadataMetrics.TABLE_SERVICE_EXECUTION_STATUS)
: HoodieMetadataMetrics.TABLE_SERVICE_EXECUTION_STATUS;
+ String deltaCommitsMetricName = tableNameExists
Review Comment:
🤖 nit: this is now the third copy of the `tableNameExists ?
String.format("%s.%s", metadataTableName, X) : X` ternary in this block — might
be worth a tiny `qualifiedMetricName(String)` helper so the three names read as
one line each.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
