hudi-agent commented on code in PR #19948:
URL: https://github.com/apache/hudi/pull/19948#discussion_r4007080260
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/SparkFileFormatInternalRowReaderContext.scala:
##########
@@ -69,22 +70,33 @@ import scala.collection.JavaConverters._
* schema cannot be recovered from a HoodieSchema
round-trip (#18739 sub-task 4).
* Kept Spark-side so the engine-neutral schema
model stays free of Spark 4.1
* variant concepts.
+ * @param instantRangeOpt optional requested-time range applied to base and
log records before merging
*/
class SparkFileFormatInternalRowReaderContext(baseFileReader:
SparkColumnarFileReader,
filters: Seq[Filter],
requiredFilters: Seq[Filter],
storageConfiguration:
StorageConfiguration[_],
tableConfig: HoodieTableConfig,
- sparkRequiredSchema:
Option[StructType] = None)
- extends BaseSparkInternalRowReaderContext(storageConfiguration, tableConfig,
SparkFileFormatInternalRecordContext.apply(tableConfig)) {
+ sparkRequiredSchema:
Option[StructType] = None,
+ instantRangeOpt:
HOption[InstantRange] = HOption.empty())
+ extends BaseSparkInternalRowReaderContext(storageConfiguration, tableConfig,
instantRangeOpt,
+ SparkFileFormatInternalRecordContext.apply(tableConfig)) {
// Java-friendly auxiliary constructor (Scala default args don't generate
matching Java overloads).
def this(baseFileReader: SparkColumnarFileReader,
filters: Seq[Filter],
requiredFilters: Seq[Filter],
storageConfiguration: StorageConfiguration[_],
tableConfig: HoodieTableConfig) =
- this(baseFileReader, filters, requiredFilters, storageConfiguration,
tableConfig, None)
+ this(baseFileReader, filters, requiredFilters, storageConfiguration,
tableConfig, None, HOption.empty())
+
+ def this(baseFileReader: SparkColumnarFileReader,
Review Comment:
🤖 nit: we now have three Java-friendly auxiliary constructors here differing
only by which trailing optional params are included. Might be worth a comment
above them noting they exist purely to work around Scala default args not
generating Java overloads, so future readers don't try to collapse them.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
