hudi-agent commented on code in PR #19945:
URL: https://github.com/apache/hudi/pull/19945#discussion_r4007052624
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSource.scala:
##########
@@ -1450,6 +1450,28 @@ class TestCOWDataSource extends
HoodieSparkClientTestBase with ScalaAssertionSup
assertTrue(recordsReadDF.filter(col("_hoodie_partition_path") =!=
udf_date_format(col("current_ts"))).count() == 0)
}
+ @ParameterizedTest
Review Comment:
🤖 nit: the method name doesn't make it clear this is testing the SCALAR +
MILLISECONDS combo specifically vs just "scalar" generally — maybe
`testSparkPartitionByWithTimestampBasedKeyGeneratorScalarMillis` to mirror the
EPOCHMILLISECONDS test name pattern.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
