voonhous opened a new pull request, #19953:
URL: https://github.com/apache/hudi/pull/19953
The Trino E2E job built the hudi-trino connector against the trinodb/trino
commit pinned by trino.sha but ran it on the released
trinodb/trino:<trino.e2e.version> image. Master tracks Trino master, so the two
always differ, and an SPI drift gate skipped every step after it while the job
still reported success. The suite has not run on master since the pin moved to
Trino master.
Build the server image from the pinned commit instead, so the server and the
connector always come from the same commit, and drop the drift gate:
- build_trino_server_image.sh packages trinodb/trino at trino.sha and builds
the image with Trino's own core/docker/build.sh.
- The E2E job caches that image per pin and loads it on a hit, then bakes
the plugin on top via build_image.sh --base-image.
- The Dockerfile takes TRINO_BASE_IMAGE; the released image stays the
default for quick local runs.
trino.e2e.version keeps feeding trino-jdbc for the integ tests.
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
