hudi-agent commented on code in PR #19959:
URL: https://github.com/apache/hudi/pull/19959#discussion_r4018168810
##########
release/release_guide.md:
##########
@@ -312,7 +312,25 @@ Source Release step) -- otherwise the voted tarball ships
a `-SNAPSHOT` Trino pi
5. Verify the released Trino resolves from Central against an empty local
repository
(scope the check to io.trino: the module's hudi siblings are not on Central
until this release completes):
`mvn dependency:get -Dartifact=io.trino:trino-hive:NNN
-Dmaven.repo.local=$(mktemp -d)`
-6. CI and the E2E workflow then run with zero SPI drift; the staging deploy
flow in "Build a release candidate"
+6. Check for dependency drift before cutting the RC: hudi-trino compiles and
tests against Hudi's managed versions,
+ while the plugin bundles Trino's `NNN` versions. Dispatch the drift check
on the release branch and read the
+ table in the run's job summary (exit 1 and a `Dependency drift` warning
mean drift):
Review Comment:
🤖 Small accuracy point: the dispatched workflow doesn't exit 1 on drift —
the compare step captures the script's rc, sets `drift=true`, and the run stays
green (with the warning annotation + summary table, and an issue filed). "exit
1" only applies to the local `check_dependency_drift.py` run below. Might be
worth rewording so a release manager doesn't wait for a red run that never
comes.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
