hudi-agent commented on code in PR #19953: URL: https://github.com/apache/hudi/pull/19953#discussion_r4021627092
########## hudi-trino/README.md: ########## @@ -89,9 +89,16 @@ TRINO_VERSION=$(sed -n 's|.*<trino.version>\(.*\)</trino.version>.*|\1|p' pom.xm mvn -f docker/trino/shim/pom.xml clean package -DskipTests -Ddep.hudi.version="$HUDI_VERSION" unzip -o -q "docker/trino/shim/target/trino-hudi-$TRINO_VERSION.zip" -d docker/trino/shim/target # trino-maven-plugin 24 emits only the zip -# 4. Build the Trino image (locally tagged; never published). The base server defaults to -# trino.e2e.version; pass --trino-version to override it. -docker/trino/build_image.sh --plugin-dir "docker/trino/shim/target/trino-hudi-$TRINO_VERSION" +# 4a. Optional, JDK 25: build the server image from a trinodb/trino checkout at trino.sha +# (the same one bootstrap used). Builds the whole trino repo, so it takes a while. Review Comment: 🤖 nit: this step is labeled "4a" but it's listed before step "4" in the numbered flow — might read clearer as "3a" or by reordering so "4a" follows "4". <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
