zhaoyudi-creator commented on code in PR #19951:
URL: https://github.com/apache/hudi/pull/19951#discussion_r4024213823


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -435,6 +439,15 @@ private CompletableFuture<CoordinationResponse> 
handleInFlightInstantsRequest(Co
     return 
CompletableFuture.completedFuture(CoordinationResponseSerDe.wrap(coordinationResponse));
   }
 
+  private CompletableFuture<CoordinationResponse> 
handlePendingBucketFileIdsRequest(Correspondent.PendingBucketFileIdsRequest 
request) {

Review Comment:
   Agreed on both concerns. The RPC timeout in particular is something we 
actually ran into during our 1.1 testing, so it's a real failure mode rather 
than a theoretical one. Let me rethink the approach.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to