danny0405 commented on code in PR #19304:
URL: https://github.com/apache/hudi/pull/19304#discussion_r4043524339
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/OptionsResolver.java:
##########
@@ -726,11 +730,52 @@ public static Option<Partitioner>
getInsertPartitioner(Configuration conf) {
}
/**
- * Returns whether complex keygen encodes single record key with field name.
+ * Returns whether the configured key generator is the complex key generator
(Avro or Spark flavour).
*/
- public static boolean useComplexKeygenNewEncoding(Configuration conf) {
- return
Boolean.parseBoolean(conf.getString(HoodieWriteConfig.COMPLEX_KEYGEN_NEW_ENCODING.key(),
-
HoodieWriteConfig.COMPLEX_KEYGEN_NEW_ENCODING.defaultValue().toString()));
+ public static boolean isComplexKeyGenerator(Configuration conf) {
Review Comment:
Flink does not utilitize the key generaor class, the logic is unidifed in
`RowDataKeyGen`, we can set up the required table options in
`HoodieTableFactory` and read the options from the conf passed into
`RowDataKeyGen`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
