hudi-agent commented on code in PR #19984:
URL: https://github.com/apache/hudi/pull/19984#discussion_r4043862536
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/lsm/HoodieLsmFileGroupReader.java:
##########
@@ -142,10 +145,14 @@ private HoodieLsmFileGroupReader(
.sortOutputs(false)
.inflightInstantsAllowed(allowInflightInstants)
.build();
- // filter log files by instant range.
- if (logFiles != null && readerContext.getInstantRange().isPresent()) {
- InstantRange instantRange = readerContext.getInstantRange().get();
- logFiles = logFiles.filter(logFile ->
instantRange.isInRange(logFile.getDeltaCommitTime()));
Review Comment:
🤖 For what it's worth, this matches what the legacy log path already does
independently of `InstantRange`: `BaseHoodieLogRecordReader` (around L296)
skips any data/delete block whose `INSTANT_TIME` header is greater than
`readerContext.getLatestCommitTime()`, and only applies `InstantRange` on top
of that. The Spark time-travel path sets `latestCommitTime` without an
`InstantRange`, so the LSM reader had no upper bound at all — this change just
brings it to parity at file granularity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
