voonhous commented on code in PR #18776:
URL: https://github.com/apache/hudi/pull/18776#discussion_r4060564348
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/BaseCreateHandle.java:
##########
@@ -128,6 +129,7 @@ protected void doWrite(HoodieRecord record, HoodieSchema
schema, TypedProperties
} catch (Throwable t) {
log.error("Error writing record {}", record, t);
if (!config.getIgnoreWriteFailed()) {
+ closeFileWriterQuietly(t);
Review Comment:
**minor:** With Flink's default `write.ignore.failed=false`, this marks the
handle closed, so `FlinkCreateHandle.closeGracefully` now gets a normal return
from `close()` and never reaches `storage.deleteFile(path)` (the HUDI-1895
#2938 cleanup). The partial file, now with a valid footer, stays until markers
or the retry-time `deleteInvalidDataFile` remove it. Not blocking, but could
`closeGracefully` delete `path` when the handle was closed by a write failure,
with a Flink test for a failed write followed by `closeGracefully`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
