prashantwason opened a new pull request, #20029:
URL: https://github.com/apache/hudi/pull/20029
HoodieFileGroupReaderBasedFileFormat.shortName() returned "HudiFileGroup"
(mixed case), which failed to match Spark's lowercased allowlist in
DataSourceUtils.supportNestedPredicatePushdown(). This silently disabled nested
struct predicate pushdown (e.g., msg.field = 'value'), causing PushedFilters:
[] in the physical plan and forcing full row group reads.
Fix:
- Change shortName() to return "hoodiefilegroup" (lowercase) so it can match
the allowlist after Spark lowercases it.
- Add "hoodiefilegroup" to the supportedFileSources config in
HoodieSparkSessionExtension via an injected optimizer rule.
- Add unit test verifying nested struct predicates appear in PushedFilters.
Impact: On tables with nested struct columns, this was causing up to 88x
more data reads (27.4 TB vs 309 GB observed in production benchmarks). Affects
all Hudi users on any Spark 3.x.
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
