sumitsingh-in commented on code in PR #19822:
URL: https://github.com/apache/hudi/pull/19822#discussion_r4081680903


##########
hudi-spark-datasource/hudi-spark4.0.x/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/Spark40LegacyHoodieParquetFileFormat.scala:
##########
@@ -152,10 +152,11 @@ class Spark40LegacyHoodieParquetFileFormat(private val 
shouldAppendPartitionValu
     val datetimeRebaseModeInRead = parquetOptions.datetimeRebaseModeInRead
     val int96RebaseModeInRead = parquetOptions.int96RebaseModeInRead
     val timeZoneId = Option(sqlConf.sessionLocalTimeZone)
-    // Should always be set by FileSourceScanExec creating this.
-    // Check conf before checking option, to allow working around an issue by 
changing conf.
+    // Respect the plan-time OPTION_RETURNING_BATCH decision when present, 
instead of recomputing it here.
     val returningBatch = 
sparkSession.sessionState.conf.parquetVectorizedReaderEnabled &&

Review Comment:
   we are not changing existing check. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to