ashokraminedi commented on code in PR #20042:
URL: https://github.com/apache/hudi/pull/20042#discussion_r4087558985
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataMetrics.java:
##########
@@ -95,6 +95,10 @@ public HoodieMetadataMetrics(HoodieMetricsConfig
metricsConfig, HoodieStorage st
}
public Map<String, String> getStats(boolean detailed, HoodieTableMetaClient
metaClient, HoodieTableMetadata metadata, Set<String> metadataPartitions) {
+ return computeStats(detailed, metaClient, metadata, metadataPartitions);
Review Comment:
Good point. I kept getStats(...) because it was already a public method, and
removing it could break existing callers. It just delegates to
computeStats(...), so there’s still one place where the stats are calculated.
Happy to simplify it if you think compatibility isn’t a concern here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
