voonhous opened a new issue, #20044: URL: https://github.com/apache/hudi/issues/20044
### Problem `mvn versions:set` does not update `dep.hudi.version` in `docker/trino/shim/pom.xml`, and the release guide does not say so. During the 1.2.1 finalize, the version commit on `release-1.2.1` (2c2ae3cbbac3) moved every other pom from `1.2.1-rc2` to `1.2.1` but left the shim at `1.2.1-rc2`. It had to be fixed by hand. The RC bumps also changed it by hand. `versions:set` cannot reach it for three reasons: - The shim is not in any `<modules>` list, so it is outside the reactor. - Its parent is `io.trino:trino-root`, not the Hudi root pom. - The Hudi version is a plain literal property. `versions:set-property` would need the Trino parent to resolve, and it cannot while master pins a Trino SNAPSHOT. CI and the docs are not affected. `hudi_trino_e2e.yml`, `hudi_trino_dependency_drift.yml` and the READMEs all pass `-Ddep.hudi.version` from the reactor version. The stale default only matters when someone builds the shim from a source release without that flag. In that case it points at an RC artifact that is gone once the staging repo is dropped. ### Proposed fix - `release/release_guide.md`: add a step after each `versions:set` (RC bump, finalize) to edit `dep.hudi.version` in the shim by hand, plus a check that `git grep -n '<old-version>' -- '*pom.xml'` returns nothing. - `scripts/release/cut_release_branch.sh`: add the matching `sed` on the shim next to both `versions:set` calls (master SNAPSHOT bump and release-branch RC bump). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
