voonhous opened a new pull request, #20051: URL: https://github.com/apache/hudi/pull/20051
### Describe the issue this Pull Request addresses `HoodieTableConfigUtils` holds five partition-field statics (`getPartitionFieldPropForKeyGenerator`, `getPartitionFieldProp`, `getPartitionFields`, `getPartitionFieldWithoutKeyGenPartitionType`, `getTableVersion`) that also exist on `HoodieTableConfig` under the same names. Nothing in the repo calls the util copies. Every caller uses the `HoodieTableConfig` versions. #11601 moved these methods into `HoodieTableConfig` and deleted `HoodieTableConfigUtils`. #11866 then brought the file back with the old bodies, most likely during a rebase. The copies have been dead since, and they have missed two later fixes to the live versions: - #11710 removed the `tableVersion > SEVEN` guard in `getPartitionFieldProp` / `getPartitionFieldWithoutKeyGenPartitionType`. The util copy still has it. - #18423 trims partition fields and splits on `BaseKeyGenerator.FIELD_SEPARATOR`. The util copy still splits on a hardcoded `","` with no trim. ### Summary and Changelog - Delete the five stale methods and their now-unused imports from `HoodieTableConfigUtils`. - Keep `inferPartitionValueExtractorClass` (added in #17850), which `HoodieTableConfig`, `HoodieSyncConfig`, `HoodieCatalogTable` and `ProvidesHoodieConfig` use. ### Impact None at runtime. The removed methods are public but have no in-repo caller. Any outside caller can switch to the method of the same name on `HoodieTableConfig`. ### Risk Level none ### Documentation Update none ### Contributor's checklist - [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [x] Enough context is provided in the sections above - [ ] Adequate tests were added if applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
