hudi-agent commented on code in PR #20020:
URL: https://github.com/apache/hudi/pull/20020#discussion_r4127109429
##########
packaging/hudi-gcp-bundle/pom.xml:
##########
@@ -99,7 +99,21 @@
<include>org.apache.hudi:hudi-hive-sync</include>
<include>org.apache.hudi:hudi-gcp</include>
<include>org.apache.parquet:parquet-avro</include>
- <include>com.google.cloud:google-cloud-bigquery</include>
+ <!-- Google Cloud SDK -->
+ <include>com.google.cloud:*</include>
+ <include>com.google.api:*</include>
+ <include>com.google.apis:*</include>
+ <include>com.google.api-client:*</include>
+ <include>com.google.api.grpc:*</include>
+ <include>com.google.auth:*</include>
+ <include>com.google.code.gson:*</include>
+ <include>com.google.http-client:*</include>
+ <include>com.google.oauth-client:*</include>
+ <include>com.google.protobuf:*</include>
+ <include>io.grpc:*</include>
Review Comment:
🤖 I don't think the broad rules predate this PR. On master the only Google
entry in this bundle's `artifactSet` is
`com.google.cloud:google-cloud-bigquery`, and the root pom doesn't add any
Cloud or gRPC includes. `com.google.cloud:*`, `com.google.api:*`,
`com.google.api.grpc:*` and `io.grpc:*` all show up as `+` lines in this diff.
Since this PR introduces them, it may be worth pinning them to the artifacts
the lock provider and BigQuery sync actually need.
##########
packaging/hudi-gcp-bundle/src/test/java/org/apache/hudi/gcp/bundle/ITGcpBundleCompatibility.java:
##########
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.gcp.bundle;
+
+import com.google.cloud.NoCredentials;
+import com.google.cloud.bigquery.BigQueryOptions;
+import com.google.cloud.storage.StorageOptions;
+import org.junit.jupiter.api.Test;
+
+import java.io.File;
+import java.lang.reflect.Method;
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+class ITGcpBundleCompatibility {
Review Comment:
🤖 nit: `runSmokeTest(boolean hostFirst)` doesn't read well at the call sites
(`runSmokeTest(true)` / `runSmokeTest(false)`) — consider a small enum like
`ClasspathOrder { HOST_FIRST, BUNDLE_FIRST }` so the two test methods are
self-documenting without needing to open the helper.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
