prashantwason commented on PR #19912: URL: https://github.com/apache/hudi/pull/19912#issuecomment-5884509267
Thanks @yihua for the review. Addressed in 4e9bd9f: - `sinceVersion` → `1.3.0`. - Reverted the `HoodieFileIndex.sizeInBytes` change — `HoodieIncrementalFileIndex` already overrides it, and the base-class change would stop Spark from broadcasting genuinely empty/pruned-away snapshot relations. - `getIncrementalFilesSize` now returns `Long.MaxValue` when `fullTableScan` is set (V1 and V2), since the listing then covers the whole table and summing `affectedFilesInCommits` would underestimate. - Added a test asserting the incremental relation's `sizeInBytes` with the option on and off. Re #19898: yes — the `sizeInBytes == 0` was observed with the prune rule skipped for incremental reads, so this is the companion to #19898. I've noted that in the description; they should land together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
