zhang-arvin commented on PR #19970: URL: https://github.com/apache/hudi/pull/19970#issuecomment-5886214729
CI on `03176df`: the single failing check (`integration-tests (spark3.5, flink2.2, spark-3.5.9/...)`) was self-inflicted. `SparkMain` passed the whole argv to JCommander, but the CLI call sites append their extra configs after the named block, so parsing died with `Was passed main parameter 'hoodie.compact.inline.max.delta.commits=1' but no main parameter was defined in your arg class` — which matches exactly the ITs that pass `--hoodieConfigs` (5/7 failures in `ITTestCompactionCommand`, 2/3 in `ITTestClusteringCommand`, 2/5 in `ITTestTableCommand`), while every other CLI IT stayed green. Fixed in `03176df`: the trailing configs are declared as a main parameter on `NamedArgs` and forwarded behind the positional slots, so `makeConfigs`/`getPropsFilePath` see the same argv as the legacy positional form. Verified locally that all 23 `addNamedAppArgs` call sites expand to the identical positional argv. CI is re-running on the new head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
