hudi-agent commented on code in PR #20021:
URL: https://github.com/apache/hudi/pull/20021#discussion_r4135390259
##########
hudi-agent-gateway/skills/hudi-architect/redact_sensitive_values.py:
##########
Review Comment:
🤖 **Line 44:** Now that `JSON_ASSIGNMENT` is gone, a quoted key with a space
or colon doesn't match anymore. `{"client secret": "s3cr3t"}`, `{"Secret Access
Key": "abc"}` and `{'db:password': 'x'}` were redacted by the previous version
but now pass through unchanged. Could the quoted-key branch accept
`[^"'\r\n]+`, with a regression case added to the parametrized test?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
