voonhous commented on PR #20188: URL: https://github.com/apache/hudi/pull/20188#issuecomment-5995485456
No where for me to inline this but: IIRC, NBCC may also repeat file ids across partitions (`newBucketFileIdForNBCC.`). So, it's not only hive tables or tables outside of hudi that exhibit such behaviours. Let's reword the PR a little so we don't give the wrong premise. Maybe we can add a test for the NBCC case to `TestSparkNonBlockingConcurrencyControl` bulk_insert into 2 partitions with the record and secondary indexes on, then upsert or delete in both? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
