ashokraminedi commented on code in PR #20193:
URL: https://github.com/apache/hudi/pull/20193#discussion_r4214420005
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieFileGroupReaderBasedFileFormat.scala:
##########
@@ -346,8 +346,8 @@ class HoodieFileGroupReaderBasedFileFormat(tablePath:
String,
val dataStructTypeWithMandatoryPartitionFields =
StructType(dataStructType.fields ++ partitionSchema.fields.filter(f =>
mandatoryFields.contains(f.name) && !isNestedPartitionField(f.name)))
val dataSchema = HoodieSchemaUtils.pruneDataSchema(schema,
HoodieSchemaConversionUtils.convertStructTypeToHoodieSchema(dataStructTypeWithMandatoryPartitionFields,
sanitizedTableName), exclusionFields)
-
spark.sessionState.conf.setConfString("spark.sql.parquet.enableVectorizedReader",
supportVectorizedRead.toString)
-
+ // Keep vectorization query-local; mutating the session configuration here
leaks this
Review Comment:
Thanks for pointing this out! I tried removing the two setConfString calls,
but 7 existing incremental-read tests failed, returning records outside the
requested commit range.
I also added temporary assertions confirming the session configuration
mutation. After restoring the overrides, the incremental-read tests passed, and
all 12 tests passed once the temporary assertions were removed.
Since this needs further investigation, I'll leave it out of this PR to keep
the vectorized-reader fix focused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
