hudi-agent commented on code in PR #20228:
URL: https://github.com/apache/hudi/pull/20228#discussion_r4235327788
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/BaseHoodieCatalystExpressionUtils.scala:
##########
@@ -72,8 +72,9 @@ abstract class BaseHoodieCatalystExpressionUtils extends
HoodieCatalystExpressio
case ToUTCTimestamp(OrderPreservingTransformation(attrRef), _) =>
Some(attrRef)
// String Expressions
- case Lower(OrderPreservingTransformation(attrRef)) => Some(attrRef)
- case Upper(OrderPreservingTransformation(attrRef)) => Some(attrRef)
+ // NOTE: Lower/Upper are not matched: case folding does not preserve
the binary ordering
+ // of strings (for ex, "Zebra" < "apple", but lower("Zebra") =
"zebra" > "apple")
+
// Left API change: Improve RuntimeReplaceable
Review Comment:
🤖 nit: could you drop the trailing blank line after this NOTE so it doesn't
read as dangling before the `Left` comment?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
