hudi-agent commented on code in PR #20278:
URL: https://github.com/apache/hudi/pull/20278#discussion_r4237328221
##########
hudi-spark-datasource/hudi-spark3.5.x/src/main/scala/org/apache/spark/sql/parser/HoodieSpark3_5ExtendedSqlParser.scala:
##########
@@ -85,7 +85,7 @@ class HoodieSpark3_5ExtendedSqlParser(session: SparkSession,
delegate: ParserInt
parser.addErrorListener(ParseErrorListener)
// parser.legacy_setops_precedence_enabled =
conf.setOpsPrecedenceEnforced
parser.legacy_exponent_literal_as_decimal_enabled =
conf.exponentLiteralAsDecimalEnabled
- parser.SQL_standard_keyword_behavior = conf.ansiEnabled
+ parser.SQL_standard_keyword_behavior = conf.enforceReservedKeywords
Review Comment:
🤖 non-blocking: In the forked `SqlBase.g4`, `TIMESTAMP` is only in
`nonReserved`, not `ansiNonReserved`, and `primitiveDataType`/`typeConstructor`
go through `identifier`, so with `spark.sql.ansi.enforceReservedKeywords=true`
a `BLOB` table with a `TIMESTAMP` column still fails even though stock Spark
accepts it; would it make sense to track that in a follow-up (or add
`TIMESTAMP` to the forked `ansiNonReserved`)?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
