danny0405 commented on code in PR #20282:
URL: https://github.com/apache/hudi/pull/20282#discussion_r4250476087
##########
hudi-common/src/main/java/org/apache/hudi/common/model/MetaFieldsMode.java:
##########
@@ -184,9 +184,12 @@ private static MetaFieldsMode parse(String rawMode) {
/**
* @return the equivalent value of the deprecated {@code
hoodie.populate.meta.fields} boolean, so
* that call sites not yet migrated to this enum keep observing consistent
behavior.
+ *
+ * <p>Only {@link #NONE} maps to {@code false}: the boolean says whether any
meta column is
+ * populated, not which. Use {@link #isRecordKeyPopulated()} for
key-dependent checks.
*/
public boolean toLegacyPopulateMetaFields() {
- return this == ALL;
+ return this != NONE;
Review Comment:
the fix does not make sense, the old `hoodie.populate.meta.fields` as false
means there is no meta fields populated, for backward compatibility of
selective mode, let's keep to infer it as false because these modes are
introduced in newer table versions which does not support in older release,
deem it as no population is more safe and strict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
