hudi-agent commented on code in PR #20297:
URL: https://github.com/apache/hudi/pull/20297#discussion_r4254138745
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieNativeLogFileReader.java:
##########
@@ -51,18 +52,18 @@ public class HoodieNativeLogFileReader implements
HoodieLogFormat.Reader {
private final InternalSchema internalSchema;
private final List<String> orderingFieldNames;
private final String partitionPath;
- private final Properties props;
+ private final Lazy<TypedProperties> props;
Review Comment:
🤖 nit: could you rename this field to `lazyProps` (or add a short comment)?
`props.get()` reads like a plain getter and hides that the copy happens on
first call.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
