hudi-agent commented on code in PR #20304:
URL: https://github.com/apache/hudi/pull/20304#discussion_r4259013447
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/cdc/HoodieCDCFileIndex.scala:
##########
@@ -57,7 +59,10 @@ class HoodieCDCFileIndex(override val spark: SparkSession,
.startInstant(options.getOrElse(DataSourceReadOptions.START_COMMIT.key(),
throw new HoodieException(s"CDC Query should provide the valid start
completion time "
+ s"through the option ${DataSourceReadOptions.START_COMMIT.key()}")
- ))
+ ) match {
Review Comment:
🤖 nit: could you pull the start-instant resolution (required check plus the
`earliest` mapping) into a small local val or helper before the builder chain?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
