danny0405 commented on code in PR #20310:
URL: https://github.com/apache/hudi/pull/20310#discussion_r4266239325
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -870,6 +869,8 @@ public void restoreToSavepoint() {
* @param savepointTime Savepoint time to rollback to
*/
public void restoreToSavepoint(String savepointTime) {
+ // validate before the metadata table may be deleted below
+
SavepointHelpers.validateNoArchivedCommitsAfterSavepoint(createMetaClient(false),
savepointTime);
Review Comment:
`metaClient.getArchivedTimeline` this is very costly, can we keep the
original validation, since the write config already validates the archive
beyond should be disabled, we can just skip the valitation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
