shangxinli commented on code in PR #20333:
URL: https://github.com/apache/hudi/pull/20333#discussion_r4272273988
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -323,7 +336,7 @@ public static HoodieRecord<HoodieMetadataPayload>
createPartitionFilesRecord(Str
// should not be creating empty files
checkState(fileSize > 0, () -> "File name " + fileName
+ ", is a 0 byte file. It does not have any contents");
- fileInfo.put(fileName, new HoodieMetadataFileInfo(fileSize, false));
+ fileInfo.put(fileName, new HoodieMetadataFileInfo(fileSize, false,
fileToSourceBasePath.get(fileName)));
Review Comment:
Agreed this needs an answer before anything sets the field. My instinct is
to gate it in the follow-up that introduces REGISTER_ONLY rather than here, via
the table property the bootstrap sets, so a reader that does not understand
registered files fails fast instead of looking for missing ones. @nsivabalan if
you would rather it be a table version or a table feature flag, happy to go
that way instead - this PR only adds the field, so the gate can land with the
writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
