hudi-agent commented on code in PR #20336:
URL: https://github.com/apache/hudi/pull/20336#discussion_r4276758850
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/transform/ErrorTableAwareChainedTransformer.java:
##########
@@ -51,12 +57,25 @@ public ErrorTableAwareChainedTransformer(List<Transformer>
transformers) {
public Dataset<Row> apply(JavaSparkContext jsc, SparkSession sparkSession,
Dataset<Row> rowDataset,
TypedProperties properties) {
Dataset<Row> dataset = rowDataset;
+ // Until the source supplies the column or a transformer keeps it, it is
known to be all null.
Review Comment:
🤖 nit: could the loop body be pulled into a small helper (e.g.
`applyPreservingCorruptRecordColumn`)? The `continue` plus the mutable
`corruptRecordMayHaveValues` flag make `apply` harder to follow.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
