skywalker0618 commented on code in PR #20337:
URL: https://github.com/apache/hudi/pull/20337#discussion_r4286778929
##########
hudi-flink-datasource/hudi-flink1.18.x/src/main/java/org/apache/hudi/table/format/cow/ParquetSplitReaderUtil.java:
##########
@@ -622,6 +624,40 @@ private static WritableColumnVector
createWritableColumnVector(
}
}
+ /**
+ * Returns the element type of a LIST physical type and its depth,
unwrapping it with the same
+ * backward-compatibility rules as {@link #getArrayElementColumn} so that
the vectors line up with
+ * the {@code ParquetField} tree.
+ */
+ private static Pair<Type, Integer> unwrapListElementType(Type listType, int
depth) {
+ Type elementType = listType;
+ String listName = null;
Review Comment:
The Javadoc of unwrapListElementType already says it applies the same
backward-compatibility rules as getArrayElementColumn. Sharing the code doesn't
fit well, since one walks the Parquet Type and the other builds the
ParquetField tree, so I'll leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
