yihua commented on code in PR #20352: URL: https://github.com/apache/hudi/pull/20352#discussion_r4286684203
########## scripts/release/rc_validation/quickstart.scala: ########## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +// Quickstart-style sanity checks for a release candidate, run through spark-shell -i. +// Covers COW and MOR via the datasource API and Spark SQL. Prints "QS PASS|FAIL <check>" +// lines and exits non-zero if any check fails. +// Required conf: spark.hudi.rc.quickstart.dir (local working directory). + +import org.apache.spark.sql.SaveMode._ +import org.apache.spark.sql.functions._ + +val workDir = spark.conf.get("spark.hudi.rc.quickstart.dir") Review Comment: We should reuse the docker demo scripts or consolidate them into a single one so that both the docker demo and the release validation can use the same, instead of maintaining multiple scripts achieving the same functionality. ########## scripts/release/validate_rc.sh: ########## @@ -0,0 +1,192 @@ +#!/bin/bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# End-to-end validation of a Hudi release candidate before voting, at a chosen scale: +# +# minimal (~5-10 min) source release checks, quickstart on the staged bundles, short HoodieStreamer +# continuous run on MOR +# decent (~15-30 min) minimal + build from the source release + HoodieStreamer tests + a larger +# HoodieStreamer run +# large (~2-4 h) decent + Spark datasource and Spark SQL test suites + high-volume +# HoodieStreamer runs on both MOR and COW Review Comment: Are these scales for functionality and performance? For performance, we should track the numbers to identify regression. ########## scripts/release/rc_validation/streamer_e2e_datagen.scala: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +// Feeds a ParquetDFSSource directory with parquet batches at a fixed interval, run through spark-shell -i. +// Batch 0 inserts `initial` keys; every later batch upserts up to `updates` existing keys and inserts +// `inserts` new keys. Each batch is staged elsewhere and then renamed into the source directory so the +// streamer never sees a partially written batch. The expected final key count is written to +// <dir>/expected_total. +// Required confs: spark.hudi.rc.e2e.{dir,batches,initial,updates,inserts,interval.seconds} + +import org.apache.hadoop.fs.{FileSystem, Path} +import org.apache.spark.sql.functions._ + +def conf(key: String) = spark.conf.get(s"spark.hudi.rc.e2e.$key") Review Comment: We should consider using #12196 and [Lake Loader](https://github.com/onehouseinc/lake-loader) to align the setup, which covers more data types and workloads; and incorporate proper scale testing as part of the release certification, instead of adding new script. Also, are the scenarios added in this PR already covered by the bundle validation as part of the [release candidate validation](https://github.com/apache/hudi/blob/master/.github/workflows/release_candidate_validation.yml)? If not, could you add the cases to the existing bundle validation to avoid duplication? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
