hudi-agent commented on code in PR #20165: URL: https://github.com/apache/hudi/pull/20165#discussion_r4288124312
########## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/metrics/FlinkHiveSyncMetrics.java: ########## @@ -32,6 +34,9 @@ * <p>A sync runs on the coordinator's Hive sync executor after a checkpoint commit, and on its event * executor after the commit that ends a bounded input, so each metric may be updated from either * thread. + * + * <p>The breakdown of each sync, from the schema read duration to the schema evolved count, is only Review Comment: 🤖 non-blocking: since the option is off by default, the breakdown metrics are still registered but `hiveSyncPartitionsAddedCount` stays at 0 forever, and its Javadoc says a flat counter means "the syncs register nothing". Would it make sense to register the breakdown metrics only when the option is set, e.g. by passing the flag in from the coordinator's `conf`? <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
