hudi-agent commented on code in PR #20359:
URL: https://github.com/apache/hudi/pull/20359#discussion_r4290876372
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamerSchemaEvolutionQuick.java:
##########
@@ -103,7 +102,11 @@ protected static Stream<Arguments> testReorderedColumn() {
for (Boolean nullForDeletedCols : new Boolean[] {false, true}) {
for (Boolean useKafkaSource : new Boolean[] {false, true}) {
for (String tableType : new String[] {"COPY_ON_WRITE",
"MERGE_ON_READ"}) {
- b.add(Arguments.of(tableType, rowWriterEnable, useKafkaSource,
nullForDeletedCols));
+ // Half fraction: every pair of factor values still appears
together in at least one row.
+ boolean evenParity = !(rowWriterEnable ^ nullForDeletedCols ^
useKafkaSource ^ tableType.equals("MERGE_ON_READ"));
Review Comment:
🤖 nit: could you simplify the XOR chain, e.g. by counting the true flags and
checking `% 2 == 0`, or by listing the 8 rows explicitly like
`logicalTypesWithJsonSourceArgs`?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
