hudi-agent commented on code in PR #20368:
URL: https://github.com/apache/hudi/pull/20368#discussion_r4291389816
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSource.scala:
##########
@@ -2594,6 +2594,37 @@ class TestMORDataSource extends
HoodieSparkClientTestBase with SparkDatasetMixin
def testNestedFieldPartition(): Unit = {
TestCOWDataSource.runNestedFieldPartitionTest(spark, basePath, storage,
"MOR")
}
+
+ @ParameterizedTest
Review Comment:
🤖 nit: could you rename the test to say what it verifies, e.g.
`testDeleteWithNestedOrderingFieldRespectsEventTimeOrdering`? Also the `"050"`
vs `"100"` strings only work as intended after the cast, which is easy to miss.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
