shangxinli commented on code in PR #20373:
URL: https://github.com/apache/hudi/pull/20373#discussion_r4304761145
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/cdc/HoodieNativeLogFormatWriter.java:
##########
@@ -193,17 +193,26 @@ private Object[] createDeleteLogFieldValues(String
recordKey, Comparable orderin
fieldValues[0] = recordContext.convertValueToEngineType(recordKey);
if (!OrderingValues.isCommitTimeOrderingValue(orderingValue)) {
if (orderingFieldNames.size() == 1) {
- fieldValues[1] = orderingValue;
+ fieldValues[1] = toDeleteLogFieldValue(orderingValue);
} else {
List<Comparable> orderingValues =
OrderingValues.getValues((ArrayComparable) orderingValue);
for (int i = 0; i < orderingValues.size(); i++) {
- fieldValues[i + 1] = orderingValues.get(i);
+ fieldValues[i + 1] = toDeleteLogFieldValue(orderingValues.get(i));
}
}
}
return fieldValues;
}
+ /**
+ * Ordering values come in their comparable form, e.g. HoodieUTF8String on
Spark, and a null ordering field as the
+ * default ordering value. The delete row holds the type the engine stores,
or NULL for a null field.
+ */
+ private Object toDeleteLogFieldValue(Comparable orderingValue) {
+ return OrderingValues.isCommitTimeOrderingValue(orderingValue)
+ ? null : recordContext.convertValueToEngineType(orderingValue);
Review Comment:
nit: on the single-field path the caller already guarded on
isCommitTimeOrderingValue, so this check can only be true for the per-element
calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
