shangxinli commented on code in PR #20353:
URL: https://github.com/apache/hudi/pull/20353#discussion_r4316649945
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogBlockMetadataScanner.java:
##########
@@ -36,12 +37,20 @@ public class HoodieLogBlockMetadataScanner extends
BaseHoodieLogRecordReader<Ind
public HoodieLogBlockMetadataScanner(HoodieTableMetaClient metaClient,
List<HoodieLogFile> logFiles,
int bufferSize, String maxInstantTime,
Option<InstantRange> instantRange) {
- super(getReaderContext(metaClient, maxInstantTime),
TableState.fromMetaClient(metaClient), metaClient.getStorage(), logFiles,
+ super(getReaderContext(metaClient, maxInstantTime),
TableState.fromMetaClient(metaClient), metaClient.getStorage(),
withoutCdcLogFiles(logFiles),
Review Comment:
Verified — the filter is on the count at line 97 now, and this scanner has
only the one production caller, so nothing else loses CDC blocks. One note on
the tests: the positive case clears a threshold of two either way, so it passes
with or without the fix; a slice with five CDC files and one data file would
actually pin it. Not blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
