voonhous commented on code in PR #20376:
URL: https://github.com/apache/hudi/pull/20376#discussion_r4314611811
##########
.github/workflows/hudi_trino_ci.yml:
##########
@@ -24,16 +24,31 @@ on:
- 'hudi-client/hudi-java-client/**'
- 'hudi-sync/hudi-sync-common/**'
- 'hudi-sync/hudi-hive-sync/**'
- # No `paths:` filter here on purpose. A path-filtered workflow is never
instantiated on
- # PRs that miss the filter, so any run of this workflow that a reviewer or a
required
- # status check expects to see would sit permanently pending. Run on every PR
instead and
- # skip the expensive steps via the detect-trino-changes job below.
(test-hudi-trino-plugin
- # is no longer a required check: the .asf.yaml contexts list was reset when
the CI matrix
- # was trimmed. Restoring the filter here is an option if runner time gets
tight again.)
+ # Path-filtered like push. test-hudi-trino-plugin is not a required check,
so a PR the filter
+ # skips simply does not show it; it must not be added to the .asf.yaml
contexts list.
pull_request:
branches:
- master
- 'release-*'
+ paths:
Review Comment:
Done, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
