n3nash commented on a change in pull request #2793:
URL: https://github.com/apache/hudi/pull/2793#discussion_r610909843
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieStorageConfig.java
##########
@@ -39,10 +39,19 @@
public static final String DEFAULT_PARQUET_BLOCK_SIZE_BYTES =
DEFAULT_PARQUET_FILE_MAX_BYTES;
public static final String PARQUET_PAGE_SIZE_BYTES =
"hoodie.parquet.page.size";
public static final String DEFAULT_PARQUET_PAGE_SIZE_BYTES =
String.valueOf(1 * 1024 * 1024);
+
public static final String HFILE_FILE_MAX_BYTES =
"hoodie.hfile.max.file.size";
public static final String HFILE_BLOCK_SIZE_BYTES =
"hoodie.hfile.block.size";
public static final String DEFAULT_HFILE_BLOCK_SIZE_BYTES = String.valueOf(1
* 1024 * 1024);
public static final String DEFAULT_HFILE_FILE_MAX_BYTES = String.valueOf(120
* 1024 * 1024);
+
+ public static final String ORC_FILE_MAX_BYTES = "hoodie.orc.max.file.size";
+ public static final String DEFAULT_ORC_FILE_MAX_BYTES = String.valueOf(120 *
1024 * 1024);
+ public static final String ORC_STRIPE_SIZE = "hoodie.orc.stripe.size";
Review comment:
Can you please add comments on what is the stripe size used for ?
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieStorageConfig.java
##########
@@ -39,10 +39,19 @@
public static final String DEFAULT_PARQUET_BLOCK_SIZE_BYTES =
DEFAULT_PARQUET_FILE_MAX_BYTES;
public static final String PARQUET_PAGE_SIZE_BYTES =
"hoodie.parquet.page.size";
public static final String DEFAULT_PARQUET_PAGE_SIZE_BYTES =
String.valueOf(1 * 1024 * 1024);
+
public static final String HFILE_FILE_MAX_BYTES =
"hoodie.hfile.max.file.size";
public static final String HFILE_BLOCK_SIZE_BYTES =
"hoodie.hfile.block.size";
public static final String DEFAULT_HFILE_BLOCK_SIZE_BYTES = String.valueOf(1
* 1024 * 1024);
public static final String DEFAULT_HFILE_FILE_MAX_BYTES = String.valueOf(120
* 1024 * 1024);
+
+ public static final String ORC_FILE_MAX_BYTES = "hoodie.orc.max.file.size";
+ public static final String DEFAULT_ORC_FILE_MAX_BYTES = String.valueOf(120 *
1024 * 1024);
+ public static final String ORC_STRIPE_SIZE = "hoodie.orc.stripe.size";
+ public static final String DEFAULT_ORC_STRIPE_SIZE = String.valueOf(64 *
1024 * 1024);
+ public static final String ORC_BLOCK_SIZE = "hoodie.orc.block.size";
Review comment:
Same for block size
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
