yihua opened a new pull request, #837:
URL: https://github.com/apache/hudi-rs/pull/837
## Description
`check-code` and `msrv-check` started failing on `main` once GitHub moved
the `ubuntu-latest` label to Ubuntu 26.04 (rollout runs Oct 19 to Nov 19, see
actions/runner-images#14748). Its newer GCC no longer pulls in `<cstdint>`
transitively, so the RocksDB 8.10 sources bundled by `librocksdb-sys 0.16` fail
with `'uint64_t' has not been declared`. RocksDB fixed the header in
facebook/rocksdb#13579, which the 8.10 line never got.
This bumps the `rocksdb` crate from 0.22 to 0.25, which bundles RocksDB
11.8.1 with the fix. The crate's default features are unchanged, and the disk
tier in `spillable_map.rs` only touches APIs that did not change between the
two versions. The new `librocksdb-sys` compiles RocksDB with `-std=c++20` and
moves to bindgen 0.72. Every CI job clears that; the one to watch is the
manylinux2014 wheel build, whose GCC 10.2.1 is below the GCC 11 floor RocksDB
documents and whose libclang 7 is below bindgen's supported range (a warning,
and RocksDB's C header uses none of the gated calls).
## How are the changes test-covered
- [ ] N/A
- [x] Automated tests (unit and/or integration tests)
- [x] Manual tests
- [x] Details are described below
Locally on macOS with the bump: `cargo clippy -p hudi-core --lib --tests --
-D warnings`, `cargo test -p hudi-core --lib` (1480 passed, including the 24
`spillable_map` tests that exercise the RocksDB tier), `cargo check --workspace
--all-targets --all-features`, and the `--no-default-features` clippy leg are
all green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
