voonhous commented on code in PR #20422:
URL: https://github.com/apache/hudi/pull/20422#discussion_r4359506402
##########
.github/workflows/validate_source.yml:
##########
@@ -48,10 +48,17 @@ jobs:
# Seconds of stdlib-only unit tests, so they run on every PR instead of
path-filtering
# on scripts/pr_compliance.py. The log goes to the runner temp dir: the
source checks below
- # copy and scan the workspace, and a stray test.log has no license
header.
+ # copy and scan the workspace, and a stray test.log has no license
header. A passing run
+ # stays quiet; a failing one prints the full log and names the failed
tests in the annotation.
- name: Test pr_compliance.py
if: ${{ !cancelled() && env.CHECK_PR_METADATA == 'true' }}
- run: python3 scripts/pr_compliance.py run-tests >
"$RUNNER_TEMP/test.log" || { echo "::error::pr_compliance.py $(cat
"$RUNNER_TEMP/test.log")" && exit 1; }
+ run: |
Review Comment:
We tested the below and the failure messages are shown:
| # | Violation planted in the demo | Annotation |
|---|---|---|
| 1 | PR description doesn't follow the template | "Please make sure you
have filled out the template correctly..." |
| 2 | PR title type `DNM` isn't allowed | `Unknown release type "DNM"...`
plus the allowed types |
| 3 | Commit `bdda9f6` has a `Co-authored-by: Claude` trailer | "Commits
with a Claude co-author trailer: bdda9f6... Remove the trailer (amend or
rebase) and force-push." (new) |
| 4 | `pr_compliance.py` broken (simulated) | "pr_compliance.py self-tests
failed: Swapped sections: 0, 1; ..." |
| 5 | `demo-validation-failures/binary.bin` is a binary file | "Binary file
in the source release..." on that file (new) |
| 6 | `no_license_header.py` and `binary.bin` lack the ASF header | "Missing
the ASF license header..." on each file (new) |
| 7 | RAT flags `no_license_header.py` | "RAT found no approved license
header..." on that file (new) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
