yihua opened a new pull request, #875:
URL: https://github.com/apache/hudi-rs/pull/875
## Description
closes #874
`Table::create` built its `Storage` from the explicit storage options only,
so credentials and settings in `AWS_*`, `AZURE_*`, `GOOGLE_*` or `HOODIE_ENV_*`
environment variables were ignored and an `s3://` create fell back to the
instance metadata endpoint, while opening the same table through `TableBuilder`
worked. The env-var resolution `TableBuilder` already does is extracted into
`resolve_storage_env_vars` and applied in create, with explicit options still
taking precedence; nothing from the environment is written into
`hoodie.properties`.
## How are the changes test-covered
- [ ] N/A
- [x] Automated tests (unit and/or integration tests)
- [ ] Manual tests
- [ ] Details are described below
A new test sets an invalid `AWS_ALLOW_HTTP` in the environment and asserts
that `create("s3://bucket/trips")` fails on that value, which shows the
variable reached the store; on `main` the same test instead fails reaching the
metadata endpoint. The existing `TableBuilder` tests pass unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
