yihua opened a new issue, #914: URL: https://github.com/apache/hudi-rs/issues/914
### Feature Description The public fields that hold an instant's completion time are named `completion_timestamp`: - `Instant::completion_timestamp` (`crates/core/src/timeline/instant.rs`) - `BaseFile::completion_timestamp` (`crates/core/src/file_group/base_file/mod.rs`) - `LogFile::completion_timestamp` (`crates/core/src/file_group/log_file/mod.rs`) Hudi Java names the same value `completionTime` (`HoodieInstant#getCompletionTime`), and hudi-rs already follows that elsewhere: `CompletionTimeView::get_completion_time`, `range_on_completion_time` in the timeline selector, and the `completion_time` field on `WriteResult` / `AppendResult` (#877). Renaming the three fields to `completion_time` gives one name for the value across the crate and matches Java. This is a breaking change to the Rust API, since all three types are public and have shipped. The fields are not exposed through the Python, C++, or FFI bindings. ### Additional context The rename also covers local variables, test helpers, and doc comments that use the old name (about 80 occurrences under `crates/core`), so the diff is mechanical but wide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
