codope commented on PR #767: URL: https://github.com/apache/hudi-rs/pull/767#issuecomment-6530024103
> Thanks for the contribution. A few comments on how the read configs are read and applied. > > Separately, the release only publishes `hudi-core`, `hudi-datafusion` and `hudi` to crates.io. Does `hudi-cpp` need to be published as well, so C++ consumers can pick up these entry points from a release? @yihua I have addressed the comments. On publishing `hudi-cpp`: I don't think crates.io gets C++ consumers much. They build through `cpp/CMakeLists.txt`, which runs cargo and the cxx-generated header, so the ASF source release, which already contains `cpp/`, is what they'd pick up. The crate also sets `[lib] name = "hudi"`, which collides with its `hudi` dependency (probably that's why `cargo test -p hudi-cpp --doc` fails with E0464), so that would need sorting out before a publish anyway. I'd rather open a separate issue on how C++ artifacts get distributed (source release only, prebuilt per-platform libs, or a vcpkg/conan port) than grow this PR. Happy to file it if that sounds right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
