nsivabalan commented on code in PR #20494: URL: https://github.com/apache/hudi/pull/20494#discussion_r4452610181
########## hudi-integ-test/spark-pipelines/materialized_views.py: ########## @@ -0,0 +1,98 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Refresh Hudi materialized views three times through the real SDP CLI.""" +import argparse +import json +from pathlib import Path +import sys +import tempfile + +SOURCE = 'from pyspark import pipelines as dp\nfrom pyspark.sql import SparkSession\nspark = SparkSession.active()\n\[email protected]_view(name="json_mv", format="hudi", table_properties={"type": "cow", "primaryKey": "id"})\ndef json_mv():\n return spark.read.schema("id INT, value STRING").json(spark.conf.get("hudi.test.input"))\n\[email protected]_view(name="hudi_mv", format="hudi", table_properties={"type": "cow", "primaryKey": "id"})\ndef hudi_mv():\n return spark.read.format("hudi").load(spark.conf.get("hudi.test.source")).select("id", "value")\n' Review Comment: Both MVs are identity projections with a `primaryKey`. The typical MV is a keyless aggregate (e.g. `GROUP BY` -> `count`), and that is where a refresh that appends instead of replacing would show up most clearly. Could this add one keyless aggregate MV, or list it as deferred in MATERIALIZED_VIEWS.md? Non-blocking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
