wombatu-kun commented on code in PR #20526:
URL: https://github.com/apache/hudi/pull/20526#discussion_r4490643651
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/dataskipping/rules/DateTimeFormatRule.scala:
##########
@@ -51,12 +52,18 @@ import scala.util.Try
object DateTimeFormatRule extends RangeRule {
override def steps(term: Expression): Seq[Step] = term match {
- case DateFormatClass(timestamp, format, _)
+ case DateFormatClass(timestamp, format, timeZoneId)
Review Comment:
Done dbb63b0a009c (rebased onto 140ad68dc13e).
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/dataskipping/rules/DateTimeOrdering.scala:
##########
@@ -124,4 +133,59 @@ object DateTimeOrdering {
// not fixed
private def isFixedOffsetZone(timeZoneId: String): Boolean =
Try(DateTimeUtils.getZoneId(timeZoneId).getRules.isFixedOffset).getOrElse(false)
+
+ private val localDateReversalsByZoneId = new ConcurrentHashMap[String,
Option[Seq[Instant]]]()
Review Comment:
Done f817838133ed; `isFixedOffsetZone` and `localDateReversals` now share
one private `rulesOf` resolver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
