voonhous commented on PR #20524: URL: https://github.com/apache/hudi/pull/20524#issuecomment-6634974311
@wombatu-kun Can you please help to review this PR, this is a pure refactor, no behaviour changes. Ideally, i will merge #20524 before #20513 and have to rebase #20513. The motivation behind this is as such: While adding the other data skipping fixes, I found `DataSkippingUtils` hard to work with, it is one flat match where every case decides everything. Since we already classify these bugs by failure mechanism and stage (#20449), #20524 splits the translation layer the same way, into four stages, so each fix lands in one place. It also enables order-reversing functions (a Decreasing direction on Step), such as negative factors and `datediff(k, col)`, which master has to reject today. This refactor has no behaviour change. The details, diagrams and the proof for the follow-up are in #20527. Intuitively, i think it makes more sense too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
